Smart Max Stack, Max Locals, and Frames Computation #539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I fixed the problem with automatic computation of max stack, max locals, and frames per method basis.
The solution is quite suboptimal since Java ASM library doesn't provide this functionality.
You can read more about this problem here.
In order to solve this problem I used reflection which has some risks for the future maintainability of CustomClassWriter:
It's better to find the proper solution for this problem in the future.
Closes: #528.
History:
PR-Codex overview
This PR refactors bytecode generation in the project. It introduces a
CustomClassWriter
and improves method writing logic.Detailed summary
CustomClassWriter
for bytecode generationBytecodeMethodProperties
ClassVisitor
withCustomClassWriter
inBytecodeMethod
BytecodeClass