Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#946): Fix All the xmir Warnings #962

Merged
merged 15 commits into from
Jan 15, 2025

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Jan 9, 2025

In this PR I fix some the warnings related to disassembled xmir.

Related to: #946.

@volodya-lombrozo volodya-lombrozo marked this pull request as draft January 9, 2025 09:30
@volodya-lombrozo
Copy link
Member Author

This PR is blocked by many other issues.

@volodya-lombrozo
Copy link
Member Author

Blocked by objectionary/eo#3812

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jan 15, 2025

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor
Copy link
Contributor

rultor commented Jan 15, 2025

@rultor merge

@volodya-lombrozo Oops, I failed. You can see the full log here (spent 6min).

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jan 15, 2025

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor
Copy link
Contributor

rultor commented Jan 15, 2025

@rultor merge

@volodya-lombrozo Oops, I failed. You can see the full log here (spent 6min).

@rultor
Copy link
Contributor

rultor commented Jan 15, 2025

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor
Copy link
Contributor

rultor commented Jan 15, 2025

@rultor merge

@volodya-lombrozo Oops, I failed. You can see the full log here (spent 6min).

@volodya-lombrozo
Copy link
Member Author

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jan 15, 2025

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit 471bd9c into objectionary:master Jan 15, 2025
8 checks passed
@rultor
Copy link
Contributor

rultor commented Jan 15, 2025

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 8min).

@volodya-lombrozo
Copy link
Member Author

@rultor release, tag is 0.7.1, title is 0.7.1

@rultor
Copy link
Contributor

rultor commented Jan 15, 2025

@rultor release, tag is 0.7.1, title is 0.7.1

@volodya-lombrozo OK, I will release it now. Please check the progress here.

@rultor
Copy link
Contributor

rultor commented Jan 15, 2025

@rultor release, tag is 0.7.1, title is 0.7.1

@volodya-lombrozo Done! FYI, the full log is here (took me 10min).

@0crat
Copy link

0crat commented Jan 17, 2025

@volodya-lombrozo Great work on your contribution! 🎉 You've earned +4 points: +4 base, +6 for 132 hits-of-code, -16 for missing code review, and +9 bonus. Keep up the momentum! Your current balance is +6. Looking forward to your next submission!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants