#320 defect formatting

objectionary · Feb 7, 2025 · f93c01c · f93c01c
1 parent 332aff9
commit f93c01c
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 4 deletions.
diff --git a/src/main/java/org/eolang/lints/Defect.java b/src/main/java/org/eolang/lints/Defect.java
@@ -129,10 +129,14 @@ public Default(
 
         @Override
         public String toString() {
-            return String.format(
-                "[%s %s %s]:%d %s",
-                this.prg, this.rle, this.sev, this.lineno, this.txt
-            );
+            final StringBuilder text = new StringBuilder(0)
+                .append('[').append(this.prg).append(' ')
+                .append(this.rle).append(' ')
+                .append(this.sev).append(']');
+            if (this.lineno > 0) {
+                text.append(':').append(this.lineno);
+            }
+            return text.append(' ').append(this.txt).toString();
         }
 
         @Override

diff --git a/src/test/java/org/eolang/lints/DefectTest.java b/src/test/java/org/eolang/lints/DefectTest.java
@@ -65,4 +65,19 @@ void printsProgramName() {
             Matchers.hasToString(Matchers.containsString(program))
         );
     }
+
+    @Test
+    void printsWithoutZeroLineNumber() {
+        MatcherAssert.assertThat(
+            "toString() prints zero for line number",
+            new Defect.Default(
+                "foo",
+                Severity.WARNING,
+                "foo.bar",
+                0,
+                "the message"
+            ),
+            Matchers.hasToString(Matchers.not(Matchers.containsString(":0")))
+        );
+    }
 }