-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create abnormalShapeOfPhysicalEntityInLocation.yaml #969
base: master
Are you sure you want to change the base?
Conversation
--- | ||
pattern_name: abnormalShapeOfPhysicalEntityInLocation | ||
pattern_iri: http://purl.obolibrary.org/obo/upheno/patterns-dev/abnormalShapeOfPhysicalEntityInLocation.yaml | ||
description: "abnormal shape of an anatomical entity or a measurement of a process, such as an ECG wave, in a location" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a serious problem with a statement like ""shape of ... measurement of a process ...", because PATO:0000052 shape is clearly defined as being a physical object quality.
An electrocardiogram (ECG) can be viewed as a measurement datum, or a timed stamped measurement datum, and then it may come in many different forms, and you could attribute some "shape" characteristics to some of its forms. However, the shape of a measurement datum does not look like one to be included in a phenotype ontology.
However, we can view an ECG as some sort of a quality of the electrophysiological characteristics of a physical object, the heart. In that case, it does not make sense at all to talk about the "shape quality" of another very specific quality.
In summary, PATO:0000052 shape should be reserved for characterising physical objects like anatomical entities, but not processes, or worse, measurement datums.
We need a better description here with better examples of when and how to use this phenotype pattern.
src/patterns/dosdp-dev/abnormalShapeOfPhysicalEntityInLocation.yaml
Outdated
Show resolved
Hide resolved
src/patterns/dosdp-dev/abnormalShapeOfPhysicalEntityInLocation.yaml
Outdated
Show resolved
Hide resolved
src/patterns/dosdp-dev/abnormalShapeOfPhysicalEntityInLocation.yaml
Outdated
Show resolved
Hide resolved
src/patterns/dosdp-dev/abnormalShapeOfPhysicalEntityInLocation.yaml
Outdated
Show resolved
Hide resolved
src/patterns/dosdp-dev/abnormalShapeOfPhysicalEntityInLocation.yaml
Outdated
Show resolved
Hide resolved
src/patterns/dosdp-dev/abnormalShapeOfPhysicalEntityInLocation.yaml
Outdated
Show resolved
Hide resolved
src/patterns/dosdp-dev/abnormalShapeOfPhysicalEntityInLocation.yaml
Outdated
Show resolved
Hide resolved
….yaml Co-authored-by: Ray Stefancsik <[email protected]>
….yaml Co-authored-by: Ray Stefancsik <[email protected]>
….yaml Co-authored-by: Ray Stefancsik <[email protected]>
….yaml Co-authored-by: Ray Stefancsik <[email protected]>
….yaml Co-authored-by: Ray Stefancsik <[email protected]>
….yaml Co-authored-by: Ray Stefancsik <[email protected]>
….yaml Co-authored-by: Ray Stefancsik <[email protected]>
Thank you for your feedback! Can you check again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Seems this was missing, can you check it?