refactor: combine exec and query database tools #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting some recoverable quoting issues with the tool arguments. Going to play with it a bit before I open it up for review. |
njhale
force-pushed
the
refactor/database
branch
from
4e01de1 to
3a13f9e
Compare
njhale
added a commit
to njhale/obot
that referenced
this pull request
Jan 25, 2025
image Addresses part of obot-platform#1448 Depends on obot-platform/tools#371 Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
refactor/database
branch
from
3a13f9e to
9640a42
Compare
squared this away with some additional context. |
njhale
requested review from
ibuildthecloud,
drpebcak,
thedadams,
tybalex,
sanjay920,
StrongMonkey,
iwilltry42,
ryanhopperlowe and
g-linville
g-linville
reviewed
Jan 27, 2025
njhale
force-pushed
the
refactor/database
branch
from
9640a42 to
5151d11
Compare
njhale
added a commit
to njhale/obot
that referenced
this pull request
Jan 27, 2025
image Addresses part of obot-platform#1448 Depends on obot-platform/tools#371 Signed-off-by: Nick Hale <[email protected]>
- Combine the `Run Database Query` and `Exec Database Statement` tools into a single `Run Database Command` tool that allows for executing both statements and queries. The new tool returns the raw SQL output instead of JSON - Shell out to the sqlite3 binary instead of using a dependency-free go module - Add the `list_database_tables` and `list_database_table_rows` system tools to retain database support in the user UI Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
refactor/database
branch
from
5151d11 to
557aba6
Compare
StrongMonkey
approved these changes
Jan 27, 2025
g-linville
approved these changes
Jan 27, 2025
njhale
added a commit
to obot-platform/obot
that referenced
this pull request
Jan 27, 2025
image Addresses part of #1448 Depends on obot-platform/tools#371 Signed-off-by: Nick Hale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run Database QueryandExec Database Statementtoolsinto a single
Run Database Commandtool that allows for executing bothstatements and queries. The new tool returns the raw SQL output
instead of JSON
module
list_database_tablesandlist_database_table_rowstools to retain database support in the user UI.
Addresses part of obot-platform/obot#1448