Tool index refactoring #403
Open
+12
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrongMonkey
force-pushed
the
tool-refactor
branch
3 times, most recently
from
0c7d47d to
d401402
Compare
StrongMonkey
requested review from
cjellick,
thedadams,
njhale,
tybalex,
iwilltry42 and
g-linville
StrongMonkey
commented
Feb 5, 2025
index.yaml
Outdated
| time: | ||
| reference: ./time | ||
| nameOverride: time |
There was a problem hiding this comment.
This is something I added to workaround a migration issue that has to deal with tool name change. Normally. under the current logic, if a tool is a bundle it has be to defined as the name x-bundle. This breaks the previous naming conversion it had with old agent/workflow. So this is just a way to override the name to not follow the same conversion.
tybalex
approved these changes
Feb 5, 2025
thedadams
approved these changes
Feb 5, 2025
njhale
approved these changes
Feb 5, 2025
StrongMonkey
force-pushed
the
tool-refactor
branch
from
d401402 to
02316e9
Compare
StrongMonkey
force-pushed
the
tool-refactor
branch
from
02316e9 to
72d008d
Compare
Signed-off-by: Daishan Peng <[email protected]>
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
force-pushed
the
tool-refactor
branch
from
72d008d to
a335d6e
Compare
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
force-pushed
the
tool-refactor
branch
from
a335d6e to
779633a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr removes category and
all: trueper obot-platform/obot#1026.The import logic will be changed in obot to accommodate it.
It doesn't rely on bundle and category metadata anymore. Category can be used to defined bigger group other than bundle.