fix: use fusejs to filter search results for slack channels and users #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
requested review from
drpebcak,
thedadams,
ivyjeong13,
tybalex,
sanjay920,
StrongMonkey,
iwilltry42,
ryanhopperlowe and
g-linville
g-linville
approved these changes
Feb 6, 2025
njhale
commented
Feb 6, 2025
| const publicChannels = publicResult.channels.filter(channel => channel.name.includes(query)) | ||
| const privateChannels = privateResult.channels.filter(channel => channel.name.includes(query)) | ||
| const result = await webClient.conversations.list({limit: 100, types: 'public_channel,private_channel'}) | ||
| const channels = (new Fuse( |
There was a problem hiding this comment.
we can improve the results for searchUsers as with this as well. maybe its worth doing it in this PR as well?
There was a problem hiding this comment.
sure I think that makes sense to do here
Update the `Search Channels` tool to use Fuse.js to filter slack channel names by similarity to the query string. Note: This may not return exact matches, but will allow LLMs to filter the channels down to results with similar names. Addresses obot-platform/obot#1660 Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
fix/slack-search-channels
branch
from
2a16d77 to
76dd764
Compare
Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
fix/slack-search-channels
branch
from
76dd764 to
e562f73
Compare
njhale
changed the title
g-linville
approved these changes
Feb 7, 2025
cjellick
approved these changes
Feb 7, 2025
thedadams
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
Search ChannelsandSearch Userstools to use Fuse.js to filter slack channel names and user names by similarity to the query string.Note: This may not return exact matches, but will allow LLMs to filter the channels and users down to results with similar names.
Addresses obot-platform/obot#1660