feat: SSAPI mvp #1951
feat: SSAPI mvp #1951
Conversation
|
|
| if err != nil { | ||
| return SearchResults{}, err | ||
| } | ||
| req.SetBasicAuth(config.Username, config.Password) |
There was a problem hiding this comment.
I should also note that we should do some oauth token authentication as well. Not sure if you have a future task pending for that
There was a problem hiding this comment.
I don't have a ticket for that right now, but I'll make one
|
|
||
| // wait for search to complete | ||
| for { | ||
| done, err := ssapir.isSearchCompleted(ssapir.config, searchID) |
There was a problem hiding this comment.
This seems like it would be wise to use a ticker approach if we're going to poll; this approach will likely be too much/overload their host if network/performance boxes are adequate/efficient.
I imagine we should have some kind of configurable job_completion_poll_interval perhaps? Know you're also working on pagination right now but do want to call out that this code needs to be refactored to not do the time.Sleeps
| ssapir.logger.Info("search completed") | ||
| return nil | ||
| } | ||
| ssapir.logger.Info("search not completed yet") |
There was a problem hiding this comment.
This may bee too much for Info level; think we should use debug level for these
| for { | ||
| select { | ||
| case <-t.C: | ||
| ssapir.logger.Info("polling for search completion") |
| logsConsumer: consumer, | ||
| config: ssapirConfig, | ||
| settings: params.TelemetrySettings, | ||
| wg: &sync.WaitGroup{}, |
There was a problem hiding this comment.
Do you have any plans for the waitgroup yet? Might be useful down the road but I think we should be careful with any async code for this receiver
There was a problem hiding this comment.
Whoops, that was left over from copying the m365 ticker, shouldn't be necessary for this.
Proposed Change
Copy the MVP of the SSAPI (formerly SHMR) to the bindplane-agent repo.
Adds query validation to the config, along with a new
limitoption.Checklist