Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] Switch pages theme #48

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

MaggieSalak
Copy link
Contributor

@MaggieSalak MaggieSalak commented Oct 21, 2024

Changes the theme to dark cayman using the modified theme from https://github.com/observability-lab-cse/lab-theme
Tested the theme and it looks ok; every section still shows the title 'Observability Workshop' as expected
image

@MaggieSalak MaggieSalak requested a review from MahrRah October 21, 2024 08:37
@MahrRah
Copy link
Contributor

MahrRah commented Oct 21, 2024

Lets maybe check if everything is correct in the custom theme before we merge :) But else looks good!

This reverts commit 03fbc41.
@MaggieSalak
Copy link
Contributor Author

MaggieSalak commented Oct 22, 2024

@MahrRah I managed to accomplish what we wanted without using our custom theme. Instead, I changed to use the dark cayman theme we wanted and just added a custom layout to make sure we always show the site title instead of the page title :)

@MahrRah
Copy link
Contributor

MahrRah commented Oct 23, 2024

Nice! I just clicked through it one thing I notices is that the drop downs are not as visible any more. Ben had the css style for those classes updated to have a background and the arrow i think. I think we should fix that as well, just to be sure they are not overlooked.
image

This reverts commit c6a4da0.
  cursor: pointer;
  color: $ms-lightblue;
h
@MaggieSalak
Copy link
Contributor Author

@MahrRah indeed there is a problem with dropdowns. I tried making this work but couldn't. At this point I've spent so much time on this that I'd say we have other lower hanging fruits and more important tasks than changing the theme :D. Unless you have an idea how to make the dropdown work, then feel free to update of course.

@MaggieSalak MaggieSalak changed the title Switch pages theme [do not merge] Switch pages theme Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants