Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks: Check for game captures needing admin #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Penwy
Copy link
Contributor

@Penwy Penwy commented Jul 27, 2024

Description

Some games require OBS to be run as admin for game capture to capture them properly, usually because they themselves are running as admin.
This usually manifests in the log with the line [game-capture: '<source name>'] could not open process: <executable>
This PR leverages this to present the user with a message informing them that running obs as admin might be needed.

To be noted, I have hesitations and would like feedback on two points of its presentation, namely, the title of the factoid, and whether listing the executables would really be useful to the user.

Motivation and Context

"Game capture no work" is not only one of the most common issues in windows support, it is also a quite obscure one. There are multiple potential causes for it, which are indistinguishable without reading the log file with special knowledge of it.
This would allow to lift this obscurity to end users on one of the possible causes.

How Has This Been Tested?

Running locally with https://obsproject.com/logs/1EHNwuIInbVRKWxI, as well as a modified version of it to check for behaviour in case of multiple executable.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Penwy Penwy force-pushed the game-capture-admin branch 2 times, most recently from 6b1db8e to 66c0d05 Compare July 27, 2024 15:42
@Penwy Penwy force-pushed the game-capture-admin branch from 66c0d05 to 108dfb2 Compare November 22, 2024 22:01
checks/windows.py Outdated Show resolved Hide resolved
checks/windows.py Outdated Show resolved Hide resolved
@Penwy Penwy force-pushed the game-capture-admin branch from 108dfb2 to cd6d889 Compare November 23, 2024 12:05
@Fenrirthviti
Copy link
Member

Fenrirthviti commented Nov 27, 2024

I need to mull over the verbiage here, but conceptually this seems fine.

I just want to be sure that it's clear admin may not resolve the issue and there might be something else going on. I thought we had a list of known games that do require admin rights, but I suppose this message is very unlikely to show up otherwise, so it's probably fine.

EDIT: for reference: https://github.com/obsproject/obs-studio/blob/master/plugins/win-capture/data/compatibility.json

@Penwy
Copy link
Contributor Author

Penwy commented Nov 28, 2024

For the wording, I could add a link to the Game capture troubleshooting page on the KB?
Has the advantages of listing the other avenues for a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants