checks: Check for game captures needing admin #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some games require OBS to be run as admin for game capture to capture them properly, usually because they themselves are running as admin.
This usually manifests in the log with the line
[game-capture: '<source name>'] could not open process: <executable>
This PR leverages this to present the user with a message informing them that running obs as admin might be needed.
To be noted, I have hesitations and would like feedback on two points of its presentation, namely, the title of the factoid, and whether listing the executables would really be useful to the user.
Motivation and Context
"Game capture no work" is not only one of the most common issues in windows support, it is also a quite obscure one. There are multiple potential causes for it, which are indistinguishable without reading the log file with special knowledge of it.
This would allow to lift this obscurity to end users on one of the possible causes.
How Has This Been Tested?
Running locally with https://obsproject.com/logs/1EHNwuIInbVRKWxI, as well as a modified version of it to check for behaviour in case of multiple executable.
Types of changes
Checklist: