Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've played with computing coverage to have an idea of how much ground we cover.
For now, the approach takes a copy of each tested
Stdlib
module and instruments that withbisect_ppx
.I do not consider this to be particularly pretty... 😅
For example, this will not report any coverage on
extern
-defined functionsNevertheless, I consider it good enough to obtain some basic numbers.
These were obtained by running the below command for the instrumented modules and computing a summary and report at the end:
I'm also including the HTML in a discard-able commit (don't know if it is viewable through the GitHub UI).
Note:
Bigarray
no coverage is reported! (4/5 tested functions defined asextern
it seems)Bytes
the simple approach needed adjusting to avoid conflicts with theBytes
required byqcheck-core
Domain
, instrumenting a copy crashes on my machine:Dynlink
- no immediatedynlink.ml
ordynlink/dynlink.ml
to copyOut_channel
coverage is for some reason reported as 0%. I'm unsure why.Thread
andThreadomain
- no immediatethread.ml
orthreads/thread.ml
to copyI'm not sure we would want this to be merged.
It gives us some numbers nevertheless that we can compare to, e.g., with the
multiple-ts
of #112