Change Control.block () to raise Sys_error when forced to return
#188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polytypic
force-pushed
the
raise-sys_error-in-case-block-is-forced-to-return
branch
11 times, most recently
from
721479e to
bc0a57c
Compare
It is technically possible to finish the computation of a fiber from outside of the fiber when using the low level Picos interface so it is not strictly impossible for the `Trigger.await` inside `Control.block ()` to return `None`.
polytypic
force-pushed
the
raise-sys_error-in-case-block-is-forced-to-return
branch
from
bc0a57c to
72726a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is technically possible to finish the computation of a fiber from outside of the fiber when using the low level Picos interface so it is not strictly impossible for the
Trigger.awaitinsideControl.block ()to returnNone.