Rewrite or refactor benchmarks using multicore-bench #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the benchmarks to use the multicore-bench framework.
This PR also adds a
bench.Dockerfile
to run the benchmarks on OCaml 5.1 (rather than the default OCaml 5.0).See also:
It is clear that many of the data structure implementations currently suffer from false sharing and some other performance pitfalls. I briefly experimented with some optimizations (avoiding false sharing, avoiding indirections, avoiding contention by using a caching mechanism) and was able to e.g. get the spsc queue to perform more than order of magnitude better (from 15M/s to over 200M/s) on my M3 Max laptop. I'm, however, intentionally leaving the proper implementation of these optimizations for future work.