Fixes verbosity flags not being respected in GLPK #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lately, on macos, we have been seeing the following logs despite keeping verbosity level to 0 ``` Constructing initial basis... Number of 0-1 knapsack inequalities = 4695 Constructing conflict graph... Conflict graph has 1691 + 294 = 1985 vertices ``` This patch correctly sets the env->term_out according the verbosity params
These changes were made for local development
|
Running some tests here: DiningPhilosophersCo/opam#1 |
|
After a few hours of debugging, I found the underlying issue: ocaml-mccs/src/glpk_solver.cpp Line 82 in 9821947 does nothing on macOS since macOS 12.7.1 / 13.6.3 / 14.2 for some reason. I’ll report the issue to Apple and see what they say. In the meantime |
|
If it's okay, I'm going to close this PR as the alternative is much cleaner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I noticed logs from GLPK backend on MacOS Azure Pipelines runner. This PR adds verbosity flag checks so that the verbosity level is respected everywhere.
TBH, I'm not so sure why this wasn't discovered earlier. Something to do with Apple/Clang?