Fix loader with paths to module types #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eg in: ``` module X : A.B.Y ``` The module type of `X` is the path to module type `A.B.Y`. This is represented in `Types` as `Mty_ident`. Before this commit it was treated as `Mty_alias` which represents module aliases (`module X = A.B.Y` where `A.B.Y` has to be a path to a module)
panglesd
commented
Feb 18, 2025
Comment on lines
+182
to
+186
| let presence = | ||
| match md_type with | ||
| | Mty_alias _ -> presence | ||
| | _ -> Mp_present (* What is this fixing? *) | ||
| in |
There was a problem hiding this comment.
Maybe a comment on why we need this is worth it
panglesd
commented
Feb 18, 2025
NathanReb
approved these changes
Feb 18, 2025
|
Don't forget to update the changelog! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #121 (with a simplified minimal reproduction in the test).
Consider the following signature items:
Here, the module type of
Ais the module type ofA.B.Y(which is a path to a module). This is represented inTypesasMty_alias path.The module type of
BisA.B.Y(which is a path to a module type). This is represented inTypesasMty_ident path.Before this PR, the two cases were treated equally, as if they were path to modules.
We now distinguish the two cases.
(This PR does not address the fact that we do not expand module types during loading! But we are not diffing them anyway as of today.)