Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only install dllzarith optional. #8

Merged
merged 1 commit into from
Jun 9, 2017
Merged

Only install dllzarith optional. #8

merged 1 commit into from
Jun 9, 2017

Conversation

bschommer
Copy link
Contributor

The normal install methods tests if dllzarith is available before
installing it, but the findlib install method always install the
dllzarith.

The normal install methods tests if dllzarith is available before
installing it, but the findlib install method always install the
dllzarith.
@xavierleroy
Copy link
Contributor

I'm not sure there still exists platforms where dynamic linking of stub libraries is not supported. But it's good to be consistent and to err on the safe side. Merging right now!

@xavierleroy xavierleroy merged commit 1e7bdb0 into ocaml:master Jun 9, 2017
@bschommer
Copy link
Contributor Author

Actually windows is affected, when certain combinations of flags are used (/z7 and /GS).

@bschommer bschommer deleted the dllzarith_opt branch June 9, 2017 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants