Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Illustrate and fix issue #1610 #1611

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Illustrate and fix issue #1610 #1611

wants to merge 7 commits into from

Commits on May 24, 2023

  1. Add a test illustrating issue ocaml#1610

    @voodoos
    voodoos committed May 24, 2023
    Configuration menu
    Copy the full SHA
    d5efb63 View commit details
    Browse the repository at this point in the history

  2. Add a test for the case where the command is given an epxlicit prefix

    @voodoos
    voodoos committed May 24, 2023
    Configuration menu
    Copy the full SHA
    20c1c23 View commit details
    Browse the repository at this point in the history

  3. test: similar for type-enclosing

    @voodoos
    voodoos committed May 24, 2023
    Configuration menu
    Copy the full SHA
    7cdcc44 View commit details
    Browse the repository at this point in the history

  4. Perform better longident parsing. 

    This fixes locate when a prefix is given, but reconstruct_identifier is still not giving the correct answer.

This also fix another issue with infix operators.
    @voodoos
    voodoos committed May 24, 2023
    Configuration menu
    Copy the full SHA
    740d244 View commit details
    Browse the repository at this point in the history

  5. tests: refactor and complete test for ocaml#949 

     about locating infix operators
    @voodoos
    voodoos committed May 24, 2023
    Configuration menu
    Copy the full SHA
    bfaa163 View commit details
    Browse the repository at this point in the history

  6. Add naive support for Papply in reconstruct identifier 

    This treat an application as a single components so it is not a satisfing long-term solution.

A better approach would be to change the return type of [reconstruct_identifier] to account for module application.

This fixes ocaml#1610
    @voodoos
    voodoos committed May 24, 2023
    Configuration menu
    Copy the full SHA
    0d8bdd9 View commit details
    Browse the repository at this point in the history

  7. test: promote broken type-enclosing test

    @voodoos
    voodoos committed May 24, 2023
    Configuration menu
    Copy the full SHA
    9d147d9 View commit details
    Browse the repository at this point in the history