[503] Use source information in uids to jump to the correct file #1857
+130,602
−14,651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from 4d6ecfb5cf4a5da814784dee7363a15ea278f324
Deduce unit info from configuration
voodoos
force-pushed
the
503-distinct-uids
branch
from
9b0730d
to
618267f
Compare
…implementation files
That way if the cmt files are outdated we don't return non-sensical results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OCaml 5.3's cmts the uids contain information indicating there origin (an implementation or an interface). In this PR we use that information to jump to interface files when needed.
This fixes issue #1848
(only the last 2 commits are relevant as this is based on the upgrade to 5.3)