Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The driver depends on sherlodoc #1197

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

EmileTrotignon
Copy link
Collaborator

The driver depends on sherlodoc, this should be reflected in the opam file. This is a first step in having the sherlodoc - odoc integration checked by CI.

@EmileTrotignon EmileTrotignon added the no changelog This pull request does not need a changelog entry label Sep 26, 2024
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge!

@Julow Julow merged commit d16bb2d into ocaml:master Sep 30, 2024
12 of 14 checks passed
@panglesd
Copy link
Collaborator

Hasn't this broken ocaml-ci ?

@Julow
Copy link
Collaborator

Julow commented Oct 1, 2024

It did! Sorry for merging too fast. I'm trying to fix this.

@panglesd
Copy link
Collaborator

panglesd commented Oct 1, 2024

I remembered I had tried that already, and unfortunately it seems that there is a problem on the ocaml-ci side: ocurrent/ocaml-ci#954 (where A is odoc, B is odoc_driver, C is sherlodoc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This pull request does not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants