Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] git-kv (0.1.0) #26802

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

robur-team
Copy link
Contributor

A Mirage_kv implementation using git

CHANGES:

CHANGES:

- Refine change_and_push semantics (fixing on GitHub robur-coop/git-kv#1 robur-coop/git-kv#2 - @reynir @dinosaure @hannesm git.robur.coop robur-coop/git-kv#2)
  - only a single task may execute it at once (using a Lwt_mutex.t to protect this)
  - abort if the state is updated in parallel by a different task while change_and_push is executing
- Do the rename inside a change_and_push (so only a single commit from a rename), git.robur.coop robur-coop/git-kv#3
- Add alcotest unit tests
- Fix CRAM tests
@hannesm
Copy link
Member

hannesm commented Oct 29, 2024

There are lower-bounds issues:

#=== ERROR while compiling git-kv.0.1.0 =======================================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.4.08.1 | pinned(https://github.com/robur-coop/git-kv/releases/download/v0.1.0/git-kv-0.1.0.tbz)
# path                 ~/.opam/4.08/.opam-switch/build/git-kv.0.1.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p git-kv -j 31
# exit-code            1
# env-file             ~/.opam/log/git-kv-7-2d83a0.env
# output-file          ~/.opam/log/git-kv-7-2d83a0.out
### output ###
# File "/home/opam/.opam/4.08/lib/eqaf/eqaf.dune", line 1, characters 0-0:
# Warning: .dune files are ignored since 2.0. Reinstall the library with dune
# >= 2.0 to get rid of this warning and enable support for the subsystem this
# library provides.
# File "test/dune", line 1, characters 0-0:
# Error: Module "Tests" is used in several stanzas:
# - test/dune:20
# - test/dune:29
# To fix this error, you must specify an explicit "modules" field in every
# library, executable, and executables stanzas in this dune file. Note that
# each module cannot appear in more than one "modules" field - it must belong
# to a single library or executable.

Any hints which dune to put as lower bound to avoid this issue? With 3.16.0, I don't observe this issue.

@hannesm hannesm force-pushed the release-git-kv-v0.1.0 branch 3 times, most recently from 42776e7 to 863a3e3 Compare October 29, 2024 14:47
@hannesm
Copy link
Member

hannesm commented Oct 29, 2024

fine to merge, CI only has some timeouts.. works fine locally

@dinosaure
Copy link
Contributor

Thanks, I noticed several Timeout on the solver just about tests. But the installation of the package seems fine.

@dinosaure dinosaure merged commit ce4637a into ocaml:master Oct 30, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants