Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] irmin (19 packages) (3.10.0) #27074

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

samoht
Copy link
Member

@samoht samoht commented Dec 11, 2024

Irmin, a distributed database that follows the same design principles as Git

CHANGES:

Added

Changed

Fixed

Removed

CHANGES:

### Added

- **irmin-git**
  - Expose `Content_addressable` type (mirage/irmin#2329, @art-w)

### Changed

- **irmin**
  - Rename `Node.S.effect` to `read_effect` for OCaml 5.3 compatibility (mirage/irmin#2347, @art-w)

### Fixed

- **irmin-client**
  - Fix a fd leak when using `clone` (mirage/irmin#2322, @samoht)
- **irmin-git**
  - Fix git sync example (mirage/irmin#2327, @art-w)
  - Fixed issue with two subsequent `Irmin-git` repos, where one
    repo would lose the ability to find its root path (mirage/irmin#2326, @zazedd)
- **irmin**
  - Fix CI, update dependencies (mirage/irmin#2321, @smorimoto)
  - Update documentation (mirage/irmin#2323, mirage/irmin#2324, mirage/irmin#2325, @christinerose)
- **irmin-cli**
  - Fix uncaught exception (mirage/irmin#2326, @art-w)

### Removed

- **irmin**
  - Removed `?allow_duplicate` parameter from the `Conf.key` function (mirage/irmin#2326, @zazedd)
@samoht
Copy link
Member Author

samoht commented Dec 11, 2024

I'm fixing the lint errors here: mirage/irmin#2350

@shonfeder
Copy link
Contributor

The windows CI failures are from the (transitive) rusage dependency, so not relevant to anything introduced here.

@shonfeder
Copy link
Contributor

shonfeder commented Dec 12, 2024

One CI failure that may of interest on https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/2ecf2dcedf527dc5dd5dd6fd8c1583505cdab018/variant/compilers,5.3~beta1,irmin-client.3.10.0,tests

<><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><>
Processing  2/3: [irmin-client: dune build]
+ /home/opam/.opam/opam-init/hooks/sandbox.sh "build" "dune" "build" "-p" "irmin-client" "-j" "39" (CWD=/home/opam/.opam/5.3~beta1/.opam-switch/build/irmin-client.3.10.0)
Processing  2/3: [irmin-client: dune runtest]
+ /home/opam/.opam/opam-init/hooks/sandbox.sh "build" "dune" "runtest" "-p" "irmin-client" (CWD=/home/opam/.opam/5.3~beta1/.opam-switch/build/irmin-client.3.10.0)
- File "test/irmin-client/dune", line 2, characters 7-11:
- 2 |  (name test)
-            ^^^^
- (cd _build/default/test/irmin-client && ./test.exe)
- Fatal error: exception Unix.Unix_error(Unix.ENAMETOOLONG, "", "/home/opam/.opam/5.3~beta1/.opam-switch/build/irmin-client.3.10.0/_build/default/test/irmin-client/test.sock")
- Fatal error: exception Unix.Unix_error(Unix.ENAMETOOLONG, "", "/home/opam/.opam/5.3~beta1/.opam-switch/build/irmin-client.3.10.0/_build/default/test/irmin-client/test.sock")
[ERROR] The compilation of irmin-client.3.10.0 failed at "dune runtest -p irmin-client".

#=== ERROR while compiling irmin-client.3.10.0 ================================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.5.3.0~beta1 | pinned(https://github.com/mirage/irmin/releases/download/3.10.0/irmin-3.10.0.tbz)
# path                 ~/.opam/5.3~beta1/.opam-switch/build/irmin-client.3.10.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p irmin-client
# exit-code            1
# env-file             ~/.opam/log/irmin-client-7-2547a7.env
# output-file          ~/.opam/log/irmin-client-7-2547a7.out
### output ###
# File "test/irmin-client/dune", line 2, characters 7-11:
# 2 |  (name test)
#            ^^^^
# (cd _build/default/test/irmin-client && ./test.exe)
# Fatal error: exception Unix.Unix_error(Unix.ENAMETOOLONG, "", "/home/opam/.opam/5.3~beta1/.opam-switch/build/irmin-client.3.10.0/_build/default/test/irmin-client/test.sock")
# Fatal error: exception Unix.Unix_error(Unix.ENAMETOOLONG, "", "/home/opam/.opam/5.3~beta1/.opam-switch/build/irmin-client.3.10.0/_build/default/test/irmin-client/test.sock")

Is this expected or accounted for?

@shonfeder
Copy link
Contributor

Is this expected or accounted for?

Ah, I see this is just a case of #14252 (comment) and only has to do with limits on the length of filenemes for sockets on certain platforms.

So the CI looks good to me than. I think this is good to merge, if desired, future releases could try to generate shorter socket names for tests to avoid this noise.

Thanks for the updates!

@shonfeder shonfeder merged commit 7f1f91d into ocaml:master Dec 12, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants