Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the detection of ZDOTDIR when using zsh #6299

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

acasta-yhliu
Copy link
Contributor

@acasta-yhliu acasta-yhliu commented Nov 15, 2024

As mentioned in #6281, ZDOTDIR is not checked when modifying env by opam init. Detection is added to src/core/openStd.ml

Fixes #6281

Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kit-ty-kate kit-ty-kate changed the title Fixed #6281, ZDOTDIR is awared by opam in now Fix the detection of ZDOTDIR when using zsh Nov 15, 2024
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kit-ty-kate
Copy link
Member

Thanks a lot!

@kit-ty-kate kit-ty-kate merged commit e687af0 into ocaml:master Nov 15, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZDOTDIR value not checked,
3 participants