-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint: add W74 to detect 'pin-depends' packages that are not present in 'depends' nor in 'depopts' #6317
Conversation
20cbb73
to
186ab9a
Compare
186ab9a
to
aed41b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code can be improved by eliminating 3 out of the 6 datatypes traverses.
The gain is small in this particular case but out of principle it feels weird to not do better if the code is as short and maybe even more understandable
I find the set transformation by pipe more human understandable (you just follow the function name, not read the code of the function given to fold). But agree on the optim part. |
aed41b2
to
e44a5f6
Compare
…n 'depends' nor in 'depopts'
e44a5f6
to
19c5b9d
Compare
Thanks! |
fix #5795
This lint doesn't detect when the versions mismatch.