commit-message: update the cmake #432 #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
看起来你对这个变量有些误解，可以看看这些信息： 看起来：
还可以参考一些其它项目的做法，比如jsoncpp，只是设置了默认值： |
|
好的好的！！我再试试！！ |
|
@LvNing-bwt 进展怎么样？需要先沟通一下吗？ |
|
我现在在学习这个cmake是什么意思
|
|
其实有一点每太看懂要干什么 |
|
这个标志看起来就是会控制不同参数下设置不同的c和c++编译选项。
有其他疑惑可以贴出来大家一起看看。
|
hnwyllmm
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem were solved in this pull request?
Issue Number: close #432
Problem:增加识别 CMAKE_BUILD_TYPE 选项，删除 DEBUG=ON Cmake选项
What is changed and how it works?
我更改了CMakeLists.txt文件，删除了DEBUG定义，新增CMAKE_BUILD_TYPE 选项的判断
更改了build.sh文件，修改了识别debug那部分命令
Other information
希望验证一下相关功能是否实现，因为不太确定是否只需要修改这两个文件以及这么修改是否正确
如果有问题，期待下一步沟通