Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/merge dashboard to master #211

Merged

Conversation

powerfooI
Copy link
Collaborator

@powerfooI powerfooI commented Feb 26, 2024

Summary

  1. Moved dashboard code outside distribution
  2. Unified test frameworks (Dashboard used strechr/testify before) to ginkgo
  3. Fixed linting problems found by golangci-lint
  4. Added licenses for all go files of dashboard and updated cooresponding CI workflows

@powerfooI powerfooI self-assigned this Feb 26, 2024
@powerfooI powerfooI removed the request for review from chris-sun-star February 26, 2024 08:17
@powerfooI powerfooI marked this pull request as draft February 26, 2024 08:18
@powerfooI powerfooI marked this pull request as ready for review February 26, 2024 09:20
@chris-sun-star chris-sun-star merged commit 42a7c9b into oceanbase:master Feb 27, 2024
4 checks passed
@powerfooI powerfooI deleted the refactor/merge-dashboard-to-master branch March 29, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants