Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cli: tenant management #577

Merged
merged 9 commits into from
Sep 30, 2024
Merged

feat: cli: tenant management #577

merged 9 commits into from
Sep 30, 2024

Conversation

lizzy-0323
Copy link
Contributor

Summary

Add cmds foir tenant management ：

  • create, list, update, upgrade, delete
  • show, scale,
  • changepwd, replaylog, switchover, activate

Solution Description

Associated issue #131

@lizzy-0323
feat: tenant management
e621b00 
chore: add alias for commands

refactor: refactor create generic

feat: tenant delete

feat: parameter config for obcluster

feat: tenant list

chore: add ci and dockerfile for cli

fix: check when creating tenant

fix: bug in creating tenant and cluster

feat: changepwd of obtenant

feat: tenant upgrade, changepwd, switchover, show ,list, etc.

feat: tenant management finish

chore: make lint

refactor: add status error handler

chore: add alias for cmds

feat: add more cmd for tenant management

refactor: scale and show in cluster

refactor: check if flags changed
@lizzy-0323
chore: delete dockerfile
197df33
@lizzy-0323
chore: add alias for install and update cmd
4cc96ac
chris-sun-star
chris-sun-star reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@chris-sun-star chris-sun-star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take care of the type and function names and log content grammar

internal/cli/cluster/create.go Outdated Show resolved Hide resolved
internal/cli/generic/generic.go Outdated Show resolved Hide resolved
internal/cli/tenant/changepwd.go Outdated Show resolved Hide resolved
internal/cli/generic/generic.go Outdated Show resolved Hide resolved
internal/cli/cmd/util/error.go Outdated Show resolved Hide resolved
internal/cli/tenant/create.go Outdated Show resolved Hide resolved
powerfooI
powerfooI reviewed Sep 30, 2024
View reviewed changes
internal/cli/cmd/cluster/scale.go Outdated Show resolved Hide resolved
internal/cli/cmd/tenant/activate.go Outdated Show resolved Hide resolved
internal/cli/cmd/tenant/changepwd.go Show resolved Hide resolved
internal/cli/cmd/tenant/show.go Outdated Show resolved Hide resolved
internal/cli/cmd/tenant/update.go Outdated Show resolved Hide resolved
internal/cli/tenant/activate.go Outdated Show resolved Hide resolved
internal/cli/tenant/switchover.go Outdated Show resolved Hide resolved
internal/cli/utils/utils.go Outdated Show resolved Hide resolved
internal/cli/utils/utils.go Outdated Show resolved Hide resolved
powerfooI
powerfooI approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@powerfooI powerfooI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chris-sun-star
chris-sun-star approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@chris-sun-star chris-sun-star left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge this PR first, I actually mean to define the default values in a seperate file, such as "local-path", you may modify these in next PR

@chris-sun-star chris-sun-star merged commit 60baa8b into oceanbase:master Sep 30, 2024
7 checks passed
@lizzy-0323 lizzy-0323 mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-sun-star chris-sun-star chris-sun-star approved these changes

@powerfooI powerfooI powerfooI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lizzy-0323 @powerfooI @chris-sun-star