Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: bugs in cluster and tenant creating #590

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Fix: bugs in cluster and tenant creating #590

merged 5 commits into from
Oct 18, 2024

Conversation

lizzy-0323
Copy link
Contributor

@lizzy-0323 lizzy-0323 commented Oct 16, 2024 •
edited
Loading

Summary

Fix bugs in creating tenant and cluster:

  1. cluster: fix wrong default values in flags, add backupVolume support when creating clusters
  2. tenant: fix parse function
  3. util: remove some characters in password that maybe escaped

Solution Description

99f4ba3^..b048580

powerfooI
powerfooI reviewed Oct 17, 2024
View reviewed changes
internal/cli/tenant/create.go Outdated Show resolved Hide resolved
internal/cli/tenant/create.go Outdated Show resolved Hide resolved
powerfooI
powerfooI approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@powerfooI powerfooI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@powerfooI powerfooI merged commit 7a92fd0 into oceanbase:master Oct 18, 2024
8 checks passed
@lizzy-0323 lizzy-0323 deleted the fix-creating-cluster-tenant branch October 18, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerfooI powerfooI powerfooI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lizzy-0323 @powerfooI