add validate function signature changes, missing update docs and others #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…col/ocean.js into issue-1913-validateddo-params
paulo-ocean
requested review from
mihaisc,
alexcos20,
bogdanfazakas,
mariacarmina and
jamiehewitt15
as code owners
|
I've changed the base of this PR to be release_4_0, so watch out for changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1913
Changes proposed in this PR:
validate" function (for validateDDO).. Ocean node needs 'nonce', 'signature' and 'publisherAddress' to validate ... signer and provider uri as extra paramscreateAssetfunction name to helpers/createAssetHelper(to avoid confusion with newer fnutils/createAsset)