refactor: Use BaseComponent

ochairo · Mar 27, 2024 · 639f776 · 639f776
1 parent 7883617
commit 639f776
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/app/features/error/presentation/error.component.ts b/src/app/features/error/presentation/error.component.ts
@@ -3,12 +3,10 @@ import template from "@error/presentation/error.component.html";
 import BaseComponent from "@infrastructure/base-component/base.component";
 
 export class ErrorComponent extends BaseComponent {
-  _shadowRoot: ShadowRoot;
   _template: string;
 
   constructor() {
     super();
-    this._shadowRoot = this.attachShadow({ mode: "open" });
     this._template = `<style>${style}</style>${template}`;
   }
 

diff --git a/src/app/features/showcase/presentation/showcase.component.ts b/src/app/features/showcase/presentation/showcase.component.ts
@@ -7,15 +7,13 @@ import template from "@showcase/presentation/showcase.component.html";
 import "../../../infrastructure/ui-components/atoms/input/input.component";
 
 class ShowcaseComponent extends BaseComponent {
-  private _shadowRoot: ShadowRoot;
   private _getShowcase: GetShowcase | null;
   private _apiData: ShowcaseData[] = [];
   router = Router.getInstance();
 
   constructor(getShowcase?: GetShowcase) {
     super();
     this._getShowcase = getShowcase || null;
-    this._shadowRoot = this.attachShadow({ mode: "open" });
   }
 
   async onInit(): Promise<void> {

diff --git a/src/app/infrastructure/base-component/base.component.ts b/src/app/infrastructure/base-component/base.component.ts
@@ -2,6 +2,12 @@
  * Base class for custom elements
  */
 export default class BaseComponent extends HTMLElement {
+  protected _shadowRoot: ShadowRoot;
+
+  constructor() {
+    super();
+    this._shadowRoot = this.attachShadow({ mode: "open" });
+  }
   connectedCallback() {
     console.log("[BaseComponent] Element connected to the DOM");
     this.onInit();