Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hashicorp/aws requirement from = 3.7.0 to 5.65.0 in /asg-elb-service #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update hashicorp/aws requirement from = 3.7.0 to 5.65.0 in /asg-elb-service #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion asg-elb-service/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
required_providers {
aws = {
source = "hashicorp/aws"
version = "= 3.7.0"
version = "5.65.0"
}
}
}
Expand All @@ -26,7 +26,7 @@
# CREATE THE ASG
# ---------------------------------------------------------------------------------------------------------------------

resource "aws_autoscaling_group" "webserver_example" {

Check failure on line 29 in asg-elb-service/main.tf

View workflow job for this annotation

GitHub Actions / terraform-scan 

CKV_AWS_315: "Ensure EC2 Auto Scaling groups use EC2 launch templates"
launch_configuration = aws_launch_configuration.webserver_example.id
vpc_zone_identifier = data.aws_subnets.default.ids

Expand All @@ -51,7 +51,7 @@
# as a variable.
# ---------------------------------------------------------------------------------------------------------------------

resource "aws_launch_configuration" "webserver_example" {

Check failure on line 54 in asg-elb-service/main.tf

View workflow job for this annotation

GitHub Actions / terraform-scan 

CKV_AWS_8: "Ensure all data stored in the Launch configuration or instance Elastic Blocks Store is securely encrypted"

Check failure on line 54 in asg-elb-service/main.tf

View workflow job for this annotation

GitHub Actions / terraform-scan 

CKV_AWS_79: "Ensure Instance Metadata Service Version 1 is not enabled"
image_id = data.aws_ami.ubuntu.id
instance_type = var.instance_type
security_groups = [aws_security_group.asg.id]
Expand Down Expand Up @@ -98,11 +98,11 @@
# usage, you should lock the Instances down so they only allow traffic from trusted sources (e.g. the ELB).
# ---------------------------------------------------------------------------------------------------------------------

resource "aws_security_group" "asg" {

Check failure on line 101 in asg-elb-service/main.tf

View workflow job for this annotation

GitHub Actions / terraform-scan 

CKV_AWS_23: "Ensure every security group and rule has a description"
name = "${var.name}-asg"
}

resource "aws_security_group_rule" "asg_allow_http_inbound" {

Check failure on line 105 in asg-elb-service/main.tf

View workflow job for this annotation

GitHub Actions / terraform-scan 

CKV_AWS_23: "Ensure every security group and rule has a description"
type = "ingress"
from_port = var.server_port
to_port = var.server_port
Expand All @@ -115,7 +115,7 @@
# CREATE AN ELB TO ROUTE TRAFFIC ACROSS THE ASG
# ---------------------------------------------------------------------------------------------------------------------

resource "aws_elb" "webserver_example" {

Check failure on line 118 in asg-elb-service/main.tf

View workflow job for this annotation

GitHub Actions / terraform-scan 

CKV_AWS_92: "Ensure the ELB has access logging enabled"

Check failure on line 118 in asg-elb-service/main.tf

View workflow job for this annotation

GitHub Actions / terraform-scan 

CKV_AWS_127: "Ensure that Elastic Load Balancer(s) uses SSL certificates provided by AWS Certificate Manager"
name = var.name
subnets = data.aws_subnets.default.ids
security_groups = [aws_security_group.elb.id]
Expand Down Expand Up @@ -143,11 +143,11 @@
# so it only allows traffic to/from trusted sources.
# ---------------------------------------------------------------------------------------------------------------------

resource "aws_security_group" "elb" {

Check failure on line 146 in asg-elb-service/main.tf

View workflow job for this annotation

GitHub Actions / terraform-scan 

CKV_AWS_23: "Ensure every security group and rule has a description"
name = "${var.name}-elb"
}

resource "aws_security_group_rule" "elb_allow_http_inbound" {

Check failure on line 150 in asg-elb-service/main.tf

View workflow job for this annotation

GitHub Actions / terraform-scan 

CKV_AWS_23: "Ensure every security group and rule has a description"
type = "ingress"
from_port = var.elb_port
to_port = var.elb_port
Expand All @@ -156,7 +156,7 @@
security_group_id = aws_security_group.elb.id
}

resource "aws_security_group_rule" "elb_allow_all_outbound" {

Check failure on line 159 in asg-elb-service/main.tf

View workflow job for this annotation

GitHub Actions / terraform-scan 

CKV_AWS_23: "Ensure every security group and rule has a description"
type = "egress"
from_port = 0
to_port = 0
Expand Down
Loading