Skip to content

Commit

Permalink
adjust grid for color issues
Browse files Browse the repository at this point in the history
  • Loading branch information
dvdherron committed Dec 18, 2023
1 parent 13ae3bd commit ea54c12
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 7 deletions.
19 changes: 15 additions & 4 deletions src/lib/components/ratio/ColorIssues.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
});
</script>

<details open={startOpen} data-pass={pass}>
<details class="known-issues" open={startOpen} data-pass={pass}>
<summary><strong>Known Color Issues</strong></summary>
<dl>
<dl class="issues-list">
<dt><strong>Gamut Mapping Implementation</strong></dt>
<dd>
<p>
Expand All @@ -29,10 +29,21 @@
</details>

<style lang="scss">
dl {
display: block;
.known-issues {
grid-area: knownissues;
padding: var(--shim) var(--double-gutter);
}
.issues-list {
display: grid;
grid-template-columns: 1fr;
grid-auto-rows: auto;
gap: var(--gutter);
}
dd {
--description-margin-inline: 0;
}
p {
margin-block-end: var(--gutter);
}
</style>
8 changes: 6 additions & 2 deletions src/lib/components/ratio/index.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,15 @@
gap: var(--result-layout-gap, var(--double-gutter));
grid-template:
'contrastinfo' min-content
'status' min-content / 1fr;
'status' min-content
'contrastdefined' min-content
'knownissues' min-content / 1fr;
@include config.between('sm-page-break', 'lg-page-break') {
--result-layout-gap: var(--gutter-plus);
grid-template: 'contrastinfo status' auto / 1fr 1fr;
grid-template:
'contrastinfo status' auto
'... knownissues' auto / 1fr 1fr;
}
@include config.above('lg-page-break') {
Expand Down
1 change: 0 additions & 1 deletion src/sass/patterns/_lists.scss
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ details {
summary {
cursor: pointer;
list-style-position: outside;
margin-block-end: var(--gutter);
}

dl {
Expand Down

0 comments on commit ea54c12

Please sign in to comment.