Take into account foreground alpha for contrast #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oddcontrast ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Superceded by #222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calculates a contrast ratio for colors with an alpha channel by mixing the color in the
srgbspace. More info on whysrgbinstead of the color's space can be found in this comment.Steps to test/reproduce
Test contrast in different spaces with different alpha levels.
Show me
I added the premultiplied color below the foreground color, as it is in essence a 3rd color that is generated.
I've added 2 boxes that show the color as blended by your display and the result of the premultiplication mix in
srgb. We may want to show this info somewhere, but likely not where it is.