Add button and drag to swap colors #227
Open
+58
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oddcontrast ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* main: lint Bump the dev-minor group across 1 directory with 15 updates Bump jsdom from 25.0.1 to 26.0.0 in the dev-major group Bump the dev-minor group with 6 updates upgrade node and yarn Bump the dev-minor group with 6 updates Bump the dev-minor group with 7 updates Bump the dev-minor group with 12 updates
jgerigmeyer
reviewed
Jan 16, 2025
Comment on lines
+85
to
+87
| const switchColorsT = () => { | ||
| switchColors(); | ||
| }; |
There was a problem hiding this comment.
Why do we need to wrap this?
Comment on lines
+88
to
+90
| const makeDropable = (event: DragEvent) => { | ||
| if (!isDragging) event.preventDefault(); | ||
| }; |
There was a problem hiding this comment.
What does this do in practice?
| role="complementary" | ||
| class="swatch {type}" | ||
| draggable="true" | ||
| ondrop={switchColorsT} |
There was a problem hiding this comment.
In practice, this means that colors are switched whenever anything is dropped onto one of the colors. E.g. I can drop an image, URL, etc. Can we limit it to just when the other color is dropped?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently not designed, this is to show possibilities.
Related Issue(s)
#108
Todo