Simplify makefiles #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sven-Thorsten Dietrich <[email protected]>
- the make files are identical after removing redundant declarations - use an include to import the common declarations - any subsequent overrides to the common declarations can be made in the module-specific makefiles below the include statement - this eliminates maintenance of around 600 lines of duplicate code without compromise in functionality Signed-off-by: Sven-Thorsten Dietrich <[email protected]>
thebigcorporation
force-pushed
the
simplify_makefiles
branch
from
9509c39
to
d4f7714
Compare
|
The optic's here are not great @[email protected] This PR has been sitting for 6 months, and the identical set of changes get committed in march with Are you folks not interested in contributions, or not interested in giving credit for contributions? commit 35388eb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set eliminates unnecessary (redundant) declarations of
default flags already set globally, and then eliminates the subsequently
identical make files, substituting a single, common makefile via the make
"include" statement.
Many of the system-specific declarations set in the remaining make file
could now more easily be discovered via a subsequent autoconf / automake
implementation.