-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-2294] Odigos set config cli command #2346
Merged
alonkeyval
merged 250 commits into
odigos-io:main
from
alonkeyval:gen-2294-odigos-set-config-command
Jan 30, 2025
Merged
[GEN-2294] Odigos set config cli command #2346
alonkeyval
merged 250 commits into
odigos-io:main
from
alonkeyval:gen-2294-odigos-set-config-command
Jan 30, 2025
+159
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntainer Task 149 sources container
…play-source-manage-list
…urces-card Task 107 overview sources card
…rce-manage-list Task 142 display source manage list
…rce-btn Task 143 add new source btn
…sources-connection Task 145 handle new sources connection
…gos-set-config-command
BenElferink
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new command to manage Odigos configuration settings and updates the Helm chart for the UI deployment to use a configuration property from a ConfigMap. The most important changes include adding a new
config
command with subcommands to set configuration properties and updating the UI deployment to reference the new configuration property.New command for managing configuration:
config
command incli/cmd/config.go
to manage Odigos configuration settings, including aset
subcommand to update specific properties.updateConfigProperty
function to update configuration properties in theodigos-config
ConfigMap.restartUIPod
function to restart the UI pod when thecentral-backend-url
property is updated.Helm chart update:
helm/odigos/templates/ui/deployment.yaml
file to use thecentralBackendURL
property from theodigos-config
ConfigMap for theCENTRAL_BACKEND_WS_URL
environment variable.