[GEN-2302]: watch for modified events, do not toast them #2370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the Kubernetes instrumentation configuration watcher and various frontend components to handle modified events and improve notification handling. The most important changes include adding support for modified events in the watcher, updating notification messages, and enhancing the CRUD operations for destinations and sources.
Kubernetes Instrumentation Configuration Watcher:
frontend/kube/watchers/instrumentation_config_watcher.go
). [1] [2]frontend/kube/watchers/instrumentation_config_watcher.go
). [1] [2]Notification Messages:
frontend/webapp/cypress/constants/index.ts
).frontend/webapp/cypress/e2e/03-sources.cy.ts
,frontend/webapp/cypress/e2e/04-destinations.cy.ts
). [1] [2]CRUD Operations Enhancements:
removePendingItems
to theuseDestinationCRUD
hook and updated theonCompleted
handler to refetch data and notify the user upon successful updates (frontend/webapp/hooks/destinations/useDestinationCRUD.ts
). [1] [2] [3]useSourceCRUD
hook to include the name of the updated source in the success notification (frontend/webapp/hooks/sources/useSourceCRUD.ts
).SSE Handling:
frontend/webapp/hooks/notification/useSSE.ts
,frontend/webapp/utils/constants/string.tsx
). [1] [2] [3]