Add cli subcommands for manipulating Sources #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damemi
force-pushed
the
sources-subcommand
branch
2 times, most recently
from
7a086eb to
3be76f3
Compare
damemi
force-pushed
the
sources-subcommand
branch
from
3be76f3 to
535cd3a
Compare
damemi
changed the title
damemi
force-pushed
the
sources-subcommand
branch
from
535cd3a to
69904d0
Compare
damemi
force-pushed
the
sources-subcommand
branch
from
69904d0 to
b42996d
Compare
RonFed
approved these changes
Feb 4, 2025
Comment on lines
+225
to
+228
| sourceFlags.StringVar(&workloadKindFlag, workloadKindFlagName, "", "Kubernetes Kind for entity (one of: Deployment, DaemonSet, StatefulSet, Namespace)") | ||
| sourceFlags.StringVar(&workloadNameFlag, workloadNameFlagName, "", "Name of entity for Source") | ||
| sourceFlags.StringVar(&workloadNamespaceFlag, workloadNamespaceFlagName, "", "Namespace of entity for Source") | ||
| sourceFlags.StringVar(&sourceGroupFlag, sourceGroupFlagName, "", "Name of Source group to use") |
There was a problem hiding this comment.
Wonder if we should add a short flag as well for these flags
There was a problem hiding this comment.
I thought about that, it's kind of annoying to type the full flag out each time
damemi
force-pushed
the
sources-subcommand
branch
from
6de5372 to
6efdc64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
odigos sourcessubcommand for manipulating Sources:odigos sources create ...odigos sources update ...odigos sources delete ...Each command takes the following flags:
--namespace: The namespace of the Source to act on--workload-kind: Applies the command to all Sources with the matching label--workload-name: Applies the command to all Sources with the matching label--workload-namespace: Applies the command to all Sources with the matching label--group: Applies the command to all Sources in the groupCreate
This command creates a Source, for example:
It requires the
kind,name, andnamespaceflags (enforced by the Source validation webhook, along with all other checks provided by that webhook).It also provides the following flags:
--disable-instrumentation: setspec.disableInstrumentation: <value>(default: false)Update
This command updates any Sources matching the label flags, for example:
Because this can update many Sources at once, there is a confirmation prompt.
It also provides the following flags:
--all-namespaces: apply the change to Sources in all namespaces--yes: Skip the confirmation prompt--set-group: Add theodigos.io/group-<value>label to the Source--remove-group: Remove theodigos.io/group-<value>label from the SourceDelete
This command deletes all Sources matching the provided labels, for example:
It also provides the following flags:
--all-namespaces: apply the change to Sources in all namespaces--yes: Skip the confirmation prompt