fix: sperate cli namespace flag for sources and install #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blumamir
commented
Feb 4, 2025
| @@ -230,7 +231,7 @@ func parseSourceLabelFlags() (string, string, string, labels.Set) { | |||
|
|
|||
| func init() { | |||
| sourceFlags = pflag.NewFlagSet("sourceFlags", pflag.ContinueOnError) | |||
| sourceFlags.StringVarP(&namespaceFlag, namespaceFlagName, "n", "default", "Kubernetes Namespace for Source") | |||
There was a problem hiding this comment.
reviewer note: the namespaceFlag is defined in install command and this line overrides it's default value odigos-system with default which leaks into the install.
BenElferink
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
sourcescli command was reusing thenamespaceFlagof the install command, setting it to default valuedefault.This leads to
odigos installtrying to install odigos into default ns if run without setting this flag.