chore: migrate ebpf manager from device to distro name env #2401
Conversation
| if distroName != "" { | ||
| // TODO: so we can remove the device slowly while having backward compatibility, | ||
| // we map here the distroNames one by one. | ||
| // this is temporary, and should be refactored once device is removed |
There was a problem hiding this comment.
Aside from removing the device fallback, is there another refactor needed here in the future?
From the comment, it seems like there is a generic way to convert distro name to language and sdk.
I assume the plan is to not have language and sdk in the futrure just use the distro name,
For that, we will need to modify the factories map keys used by the manager to be distro name.
Is that right?
There was a problem hiding this comment.
we already have `instrumentor/internal/webhook_env_injector"
I agree that they operate on different kinds of env vars, but I think those logics should be in the same package
There was a problem hiding this comment.
as I refactor this part, I intend to move the functions to the controller, similar to how it's done in the rollout directory
As part of the effort to remove instrumentation device, this PR:
ODIGOS_DISTRO_NAMEto describe the name of the distro injected to the pod./var/odigosmount, or not.