Adding context propagation to net/http server instrumentation #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it is necessary to check whether the traceparent exists before inserting elements into the map, because if the same key exists, there may be logic errors when writing the http header. |
|
@oxeye-gal any interest in re-opening this in https://github.com/open-telemetry/opentelemetry-go-instrumentation ? |
|
Hi @vreynolds, sure thing i'll do it later this week. |
|
Hey @oxeye-gal - If you would like help porting this to the OTel repo, let me know -- I'm happy to help however I can. |
JamieDanielson
added a commit
to honeycombio/opentelemetry-go-instrumentation
that referenced
this pull request
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR attempts to add context propagation to the net/http server instrumentation.
We do it by iterating over the first bucket of the incoming request header map and trying to find the "traceparent" header.
This was tested with Go versions 1.12-1.19.
Our test environment consisted of instrumented Python application that sends a request to instrumented Go http server.
The produced trace looks like the following:
We would love to get your feedback on this.
Thanks!