Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render phone number input as tel(telephone) type #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abdellahrk
Copy link

This PR fixed #153

@odolbeau
Copy link
Owner

Thanks for your contribution @abdellahrk! 🙏

This is definitively a change we want on this bundle BUT :

  • If the bug Tel input type not taken into account in twig #153 is confirmed, this PR could lead to some problems. People using this bundle will see their <input type="text" /> transformed in an <input type="tel" /> which could break their design or a script mapped to all input[type="string"] for example). In this case, we should consider releasing a new major version and document this change in a ̀UPGRADE.md` file.
  • If the bug is not confirmed (or limited to a few projects using special dependencies), I think this PR can be merged without problem directly on the current version.

WDYT @abdellahrk @Nek-?

@abdellahrk
Copy link
Author

Thank you for the comment @odolbeau,
I think @Nek- 's input will be invaluable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tel input type not taken into account in twig
2 participants