prov/efa, fabtests: Changes to support adding efa-direct fi_info objects #10759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove duplicated code in RDM and DGRAM paths - Remove duplicated checks that are available in ofi_check_info in ofi_util.h - Always use the prov_info objects from the util_prov struct instead of the device attributes - Print a warning when app requests FI_AV_MAP Signed-off-by: Sai Sunku <[email protected]>
Signed-off-by: Sai Sunku <[email protected]>
Current fabtests are designed to test the EFA RDM path which will continue to have fabric name efa. The efa-direct path will have the fabric name efa-direct and will not be selected for the current tests Signed-off-by: Sai Sunku <[email protected]>
shijin-aws
approved these changes
Feb 3, 2025
|
@j-xiong is intel ci failure related? |
|
Nvm, it's pure fabtests/pytest/efa change where Intel CI shouldn't use... I will merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate out some commits from #10735 to make review and testing easier