[v1.21.x] prov/efa: Remove unconditional assignment of err_entry #9946
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, efa_rdm_cq_poll_ibv_cq always assigns err_entry
as {0} at the beginning while err_entry is only used in the error path.
This unconditional assignment (88 bytes) caused additonal overhead
in the fast path. This patch fixes it by moving the assignment
of err_entry to the error path only
Signed-off-by: Shi Jin <[email protected]>
(cherry picked from commit 37e557e)
darrylabbate
approved these changes
Mar 28, 2024
wenduwan
approved these changes
Mar 28, 2024
|
@shijin-aws It's a little bit late for 1.21.0. Are you fine with getting it merged after 1.21.0? |
|
@j-xiong It's to fix a perf regression introduced by the earlier commits in 1.21. It will greatly appreciated if we can include this. But it's acceptable for us to merge it after the OFIWG 1.21.0 release. |
|
@shijin-aws Ok, I can get it in. Just need to restart packaging and testing. |
|
@j-xiong Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #9942