Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prov/efa: Two cleanup changes #9947

Merged
merged 2 commits into from
Mar 29, 2024
+1 −9
Merged

prov/efa: Two cleanup changes #9947

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3299864
prov/efa: remove unused cq_attr
shijin-aws Mar 28, 2024
1403c51
prov/efa: Move efa_rdm_cq_poll_ibv_cq to efa_rdm_cq.h
shijin-aws Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions prov/efa/src/efa_cq.h
View file
Original file line number Diff line number Diff line change
@@ -18,8 +18,6 @@ struct efa_ibv_cq_poll_list_entry {
struct efa_ibv_cq *cq;
};

void efa_rdm_cq_poll_ibv_cq(ssize_t cqe_to_process, struct efa_ibv_cq *ibv_cq);

static inline
int efa_ibv_cq_poll_list_match(struct dlist_entry *entry, const void *cq)
{
1 change: 1 addition & 0 deletions prov/efa/src/rdm/efa_rdm_cq.h
View file
Original file line number Diff line number Diff line change
@@ -22,4 +22,5 @@ struct efa_rdm_cq {
int efa_rdm_cq_open(struct fid_domain *domain, struct fi_cq_attr *attr,
struct fid_cq **cq_fid, void *context);

void efa_rdm_cq_poll_ibv_cq(ssize_t cqe_to_process, struct efa_ibv_cq *ibv_cq);
#endif
7 changes: 0 additions & 7 deletions prov/efa/src/rdm/efa_rdm_ep_fiops.c
View file
Original file line number Diff line number Diff line change
@@ -427,7 +427,6 @@ int efa_rdm_ep_open(struct fid_domain *domain, struct fi_info *info,
{
struct efa_domain *efa_domain = NULL;
struct efa_rdm_ep *efa_rdm_ep = NULL;
struct fi_cq_attr cq_attr;
int ret, retv, i;

efa_rdm_ep = calloc(1, sizeof(*efa_rdm_ep));
@@ -436,9 +435,6 @@ int efa_rdm_ep_open(struct fid_domain *domain, struct fi_info *info,

efa_domain = container_of(domain, struct efa_domain,
util_domain.domain_fid);
memset(&cq_attr, 0, sizeof(cq_attr));
cq_attr.format = FI_CQ_FORMAT_DATA;
cq_attr.wait_obj = FI_WAIT_NONE;

ret = efa_base_ep_construct(&efa_rdm_ep->base_ep, domain, info,
efa_rdm_ep_progress, context);
@@ -476,9 +472,6 @@ int efa_rdm_ep_open(struct fid_domain *domain, struct fi_info *info,
efa_rdm_ep->use_device_rdma = efa_rdm_get_use_device_rdma(info->fabric_attr->api_version);
efa_rdm_ep->shm_permitted = true;

cq_attr.size = MAX(efa_rdm_ep->rx_size + efa_rdm_ep->tx_size,
efa_env.cq_size);

assert(info->tx_attr->msg_order == info->rx_attr->msg_order);
efa_rdm_ep->msg_order = info->rx_attr->msg_order;
efa_rdm_ep->max_msg_size = info->ep_attr->max_msg_size;