prov/opx: Fix Coverity scan waiting while holding lock errors. #9959
Conversation
Remove busy-waiting/sleeping while SHM FIFO has not been created/initialized. Cast result of CPU_ISSET() to a uint64_t to fix a coverity warning about potentially left-shifting by more than 31 bits. Whitespace/formatting fixups. Signed-off-by: Ben Lynam <[email protected]>
|
@zachdworkin I can no longer access Intel CI status pages by clicking the "details" link of the check results. I got a page referring to a AWS site. This is likely related to #9951 and the installation of the aws CI app: https://github.com/ofiwg/libfabric/settings/installations. Could you take a look? @a-szegel Could you check from the aws ci app side? |
|
AWS CI failure is unrelated. |
|
bot:aws:retest |
@j-xiong Is it still happening now? If I click the Intel CI details it directs me to https://cje-fm-owrp-prod03.devtools.intel.com/satg-dse-ofilibfabric/job/OFIWG_Libfabric/job/ofi_libfabric/job/PR-9959/2/display/redirect which seems Intel |
|
@shijin-aws I just manually triggered Intel CI. It looks like both Jenkins CI's get triggered on PR but whichever one reports last takes the github PR check link. I am still investigating how we can fix this and have both Jenkinsfiles. |
|
@zachdworkin Thanks, @a-szegel is OOO today. Let us know if you need help from our side |
|
@shijin-aws I can't seem to find examples on google where users are sharing a git repo and are trying to connect multiple controllers AND are having this problem. It seems that the original AWS hook works (which is a different controller) so I'm curious why the new test hook is overwriting the Intel one. I think we maybe need to add a new git hook for this new Jenkinsfile or we could try what the only article I could find on this suggested; naming Jenkinsfiles differently. EG: "Jenkinsfile.intel" and "Jenkinsfile.aws". Other questions I have about the configuration of your controller for this job. What is the quiet period? Where is it looking for Jenkinsfile? What git plugins are you using? Our configurations are: @j-xiong do we know how the original (last week when we only had one job for AWS controller and one job for Intel controller) jenkins hooks got created? Can we add a new one from Git side? Are they only creatable from Jenkins side? |
|
@zachdworkin I am not quite familiar with the questions u are asking. I think the best we can do right now is to temporarily uninstall this github app and re-install it when @a-szegel is back. |
|
@shijin-aws Agreed. I can work this out with @a-szegel when they get back. In the meantime, do you think you can disable the new multibranch pipeline job from #9951 that is causing the issues? There should be a button in the top right of the job that says "disable multibranch pipeline" and that will prevent it from running/reporting. |
|
@zachdworkin I disabled this multibranch pipeline project. Let's see whether it fixes it |
|
I uninstalled the AWS CI github app. |
|
@j-xiong @zachdworkin is everything all good this time? |
|
@shijin-aws It appears to work properly now. |
|
I think I found the solution, from this issue, it seems like we need to install this plugin, and name the context so that the results do not get overridden. This should he done by both AWS and Intel to avoid this from happening again (in case another provider wants to add Jenkins multi branch pipeline to libfabric for CI) |
|
@zachdworkin Could you check the above comment from @a-szegel and take the necessary actions for Intel CI? |
|
@j-xiong Yes, its been applied. The new tag for intel ci is continuous-integration/intel/jenkins. |
|
@zachdworkin Great! |
Remove busy-waiting/sleeping while SHM FIFO has not been created/initialized. Cast result of CPU_ISSET() to a uint64_t to fix a coverity warning about potentially left-shifting by more than 31 bits. Whitespace/formatting fixups.
PR Details
This should fix most of, if not all of, the 37 "Waiting while holding a lock" Coverity scan defects (numerous CIDs).
It should also address the bad bit-shift operation (CID 376792) defect.
Lots of whitespace/formatting changes (removing trailing whitespace, proper tab use).