Skip to content

Commit

Permalink
updated CHANGELOG
Browse files Browse the repository at this point in the history
  • Loading branch information
Torkus committed Apr 8, 2023
1 parent 7e6a6e9 commit da01c84
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 10 deletions.
16 changes: 8 additions & 8 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

* jlink `compress` changed from `2` to `1` during the building of the linux AppImage
- `compress=2` means 'zip', which (I think) interferes with AppImage compression.
- this leads to shaving ~7MB off of the final AppImage.
* replaced compressed, static, 'emergency' catalogue with a simple JSON string.
* `jlink compress=2` changed to `jlink compress=1` during the building of the linux AppImage.
- `2` means 'zip', which interferes with the final AppImage compression.
- this shaves off ~7MB from the final AppImage.
* replaced the compressed, static, 'emergency' catalogue with a simple JSON string.
1. it wasn't working at compile time like I thought.
2. regular strings are more compressible ultimately when building an AppImage.
* bumped dependencies.
- removed `apache.commons.compressors` as no longer required.
* some dependencies used for development are no longer bundled during release.
* release data will only be downloaded once the app has finished loading.
* release data will only be downloaded once per-session.
- it would previously re-attempt to download release information on failure indefinitely.
* strongbox release info will only be downloaded once the app has finished loading.
* strongbox release info will only be downloaded once per-session.
- it would previously re-attempt to download the release info on failure endlessly.

### Fixed

* possible cache stampede fetching strongbox release data. a lock is now acquired to ensure checks happen sequentially.
* possible cache stampede fetching strongbox release info. A lock is now acquired to ensure checks happen sequentially.
- it was possible for the GUI to fire off many requests to Github simultaneously, bypassing cache and overwriting each other.

### Removed
Expand Down
5 changes: 3 additions & 2 deletions TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ see CHANGELOG.md for a more formal list of changes by release
* user catalogue, what is happening now that regular, non-github, addons can be favourited?
- do they need to have their details refreshed?
- also, we have a github catalogue now, I bet the majority of these updates can be pulled directly from catalogues.
- it looks like refreshing the user catalogue is actually finding the addon in the catalogue, expandinging it and then installing it
- it looks like refreshing the user catalogue is actually finding the addon in the catalogue, expanding it and then installing it
- I don't think it should be installed!
- at least, finding and installing should be separate steps
- for example, import-addon should find-addon then install-addon
- and refresh-user-catalogue-item should be find-addon and then update-catalogue
- and doesn't the catalogue it's looing in already contain the user-catalogue?
- and doesn't the catalogue it's looking in already contain the user-catalogue?

* user catalogue, schedule refreshes
- ensure the user catalogue doesn't get too stale and perform an update in the background if it looks like it's very old
Expand Down Expand Up @@ -52,6 +52,7 @@ see CHANGELOG.md for a more formal list of changes by release
- num addons favourited/user-catalogue
- num addons
- ...?
- a button on the opposite of the log popup button but similar that will show some overall stats

* display github requests remaining
- ...
Expand Down

0 comments on commit da01c84

Please sign in to comment.