Fix: Improve Mobile Responsiveness and Layout for Edit User Form #10359

modamaan · 2025-02-01T17:13:23Z

Proposed Changes

Fixes Mobile View UI: Edit User Form Needs Improved Layout and Responsive Styling #10358
Change 1

Change 2

Old

Updated

@ohcnetwork/care
-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

Style
- Improved the layout of user form fields to better adapt to smaller screens.
- Adjusted the spacing between elements on the schedule creation page for a cleaner mobile presentation.
- Updated labels to prevent text wrapping in the schedule creation form.
- Enhanced the date picker button and display logic for improved responsiveness and clarity based on screen size.

coderabbitai · 2025-02-01T17:13:32Z

Walkthrough

This pull request updates the UI layout of three components. In the user form, grid classes were modified so that form fields switch to a single column on smaller screens while retaining a two-column layout on larger devices. The schedule template sheet had its flex container gap adjusted for improved spacing on small screens. The date picker component received enhancements for responsive button widths and date display formats. No changes were made to business logic, validation, or exported entities.

Changes

File(s)	Change Summary
`src/components/Users/UserForm.tsx`	Updated responsive styling: changed grid columns for vertical stacking on smaller screens.
`src/pages/Scheduling/components/CreateScheduleTemplateSheet.tsx`	Adjusted flex gap classes for improved spacing on small screens.
`src/components/ui/date-picker.tsx`	Enhanced button width responsiveness and date display logic based on screen size.

Assessment against linked issues

Objective	Addressed	Explanation
Improve Edit User Form responsive layout and spacing (#10358)	✅

Possibly related PRs

Fix : Date field overflow in exception form in mobile view #10112: The changes in the main PR and the retrieved PR are related as both involve modifications to the layout of form fields for better responsiveness on smaller screens, specifically changing grid configurations to stack elements vertically.
Rm whatsapp phone number, hide email for updates #10334: The changes in the main PR focus on the visual layout of the UserForm.tsx, while the retrieved PR modifies the validation schema and rendering logic of the same file, indicating a direct relationship between the two.

Suggested labels

needs review, tested

Suggested reviewers

Jacobjeevan
rithviknishad

Poem

I'm a rabbit hopping through the code,
Making screens align in a responsive mode.
Fields now stack neatly, one by one,
Like carrots in a row under the sun.
Happy hops and clean layouts—code fun to behold!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 884535e and 63280bc.

📒 Files selected for processing (1)

src/components/ui/date-picker.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: cypress-run (1)

🔇 Additional comments (4)

src/components/ui/date-picker.tsx (4)

33-33: LGTM! Good responsive design pattern.

The addition of sm:w-auto class follows mobile-first principles, allowing the button to be full width on mobile devices while adapting to content width on larger screens.

36-39: LGTM! Good icon handling for responsive layout.

The icon styling changes are well thought out:

Responsive margin with mr-0 sm:mr-2 ensures proper spacing across screen sizes

Fixed icon dimensions and flex-shrink-0 prevent distortion

40-51: LGTM! Excellent responsive date format implementation.

The date display implementation is well-structured:

Uses semantic HTML with proper responsive visibility classes

Provides a concise format for mobile while maintaining detailed format for desktop

Maintains good accessibility with proper text structure

54-54: Verify popover appearance across screen sizes.

While the responsive width classes look good, please verify:

The popover's appearance on various mobile devices

The size of the arrow/chevron, as mentioned in the PR feedback

Consider adjusting the arrow size if it's too small:
-      <PopoverContent className="w-auto p-0 sm:w-64" align="start">
+      <PopoverContent className="w-auto p-0 sm:w-64 [&>arrow]:h-3 [&>arrow]:w-3" align="start">

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-01T17:14:12Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`63280bc`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67a11a44e794570008ae80a6
😎 Deploy Preview	https://deploy-preview-10359--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/pages/Scheduling/components/CreateScheduleTemplateSheet.tsx

modamaan · 2025-02-03T16:40:51Z

rithviknishad · 2025-02-03T17:04:51Z

this doesn't look nice, the arrow is too small even though there is enough space for it to be bigger.

modamaan · 2025-02-03T17:17:38Z

@rithviknishad

modamaan · 2025-02-03T19:36:07Z

old

updated

nihal467 · 2025-02-04T11:42:22Z

LGTM

github-actions · 2025-02-04T11:55:19Z

@modamaan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

modamaan added 2 commits February 1, 2025 22:22

userform ui updated on mobilescreen

5dd7882

Endtime field responsive updated

e8e5719

modamaan requested a review from a team as a code owner February 1, 2025 17:13

Jacobjeevan requested changes Feb 3, 2025

View reviewed changes

src/pages/Scheduling/components/CreateScheduleTemplateSheet.tsx Outdated Show resolved Hide resolved

Jacobjeevan added the changes required label Feb 3, 2025

whitespace-nowrap added

c13a0d1

arrowRightIcon size updated

884535e

Date overflow fixed

63280bc

modamaan requested a review from Jacobjeevan February 3, 2025 19:38

Jacobjeevan approved these changes Feb 4, 2025

View reviewed changes

Jacobjeevan added needs testing needs review and removed changes required labels Feb 4, 2025

Jacobjeevan requested a review from rithviknishad February 4, 2025 08:13

nihal467 added tested and removed needs testing labels Feb 4, 2025

rithviknishad approved these changes Feb 4, 2025

View reviewed changes

rithviknishad merged commit fdf44a4 into ohcnetwork:develop Feb 4, 2025
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Improve Mobile Responsiveness and Layout for Edit User Form #10359

Fix: Improve Mobile Responsiveness and Layout for Edit User Form #10359

modamaan commented Feb 1, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 1, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 1, 2025 •

edited

Loading

modamaan commented Feb 3, 2025 •

edited

Loading

rithviknishad commented Feb 3, 2025 •

edited

Loading

modamaan commented Feb 3, 2025 •

edited

Loading

modamaan commented Feb 3, 2025

nihal467 commented Feb 4, 2025

github-actions bot commented Feb 4, 2025

Fix: Improve Mobile Responsiveness and Layout for Edit User Form #10359

Fix: Improve Mobile Responsiveness and Layout for Edit User Form #10359

Conversation

modamaan commented Feb 1, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 1, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 1, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

modamaan commented Feb 3, 2025 • edited Loading

rithviknishad commented Feb 3, 2025 • edited Loading

modamaan commented Feb 3, 2025 • edited Loading

modamaan commented Feb 3, 2025

nihal467 commented Feb 4, 2025

github-actions bot commented Feb 4, 2025

modamaan commented Feb 1, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 1, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 1, 2025 •

edited

Loading

modamaan commented Feb 3, 2025 •

edited

Loading

rithviknishad commented Feb 3, 2025 •

edited

Loading

modamaan commented Feb 3, 2025 •

edited

Loading