This repository has been archived by the owner on Jan 12, 2025. It is now read-only.
Borg usage #24
Merged
Borg usage #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The summary for each command should be updated though. I'll update that later except if someone else wants to do it. |
|
@anas10 can you get rid of the .gitignore files? |
crufter
reviewed
Oct 12, 2016
| } | ||
| } | ||
|
|
||
| func help() { | ||
| fmt.Println("Usage: borg \"your question\"") | ||
| fmt.Print("\033[4mUsage:\033[0m\n\n") |
There was a problem hiding this comment.
This is pretty hard to read. Any way to make this better?
There was a problem hiding this comment.
yeah maybe use this kind of lib: https://github.com/fatih/color,
and enable color with a flag.
crufter
reviewed
Oct 12, 2016
| fmt.Println(err) | ||
| os.Exit(1) | ||
|
|
||
| if c, ok := commands.Commands[flag.Arg(0)]; !ok { |
There was a problem hiding this comment.
Why is the query command any special? So far the main.go was really easy to understand - if a bit manual - now it's hard to get what's going on.
slavovojacek
approved these changes
Oct 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issue #21. Improved usage and commands declaration