Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix endpoints #2

Merged
merged 4 commits into from
Dec 23, 2023
Merged

fix endpoints #2

merged 4 commits into from
Dec 23, 2023

Conversation

mxyng
Copy link
Collaborator

@mxyng mxyng commented Dec 22, 2023

chat/generate uses model while other endpoints use name

@jmorganca
Copy link
Member

jmorganca commented Dec 22, 2023 •
edited
Loading

I believe we're going to normalize everything to model soon in the REST API (still good this uses name)

@mxyng
Copy link
Collaborator Author

mxyng commented Dec 22, 2023 •
edited
Loading

Yeah I'm looking forward to that. For now, the Python interface will be model across the board. I'd also like to change copy from source/destination to source/target. Destination feels wrong for this use case

@mxyng mxyng merged commit 349d9c3 into main Dec 23, 2023
5 checks passed
@mxyng mxyng deleted the mxyng/fix branch December 23, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmorganca jmorganca jmorganca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxyng @jmorganca