Adding support for phpstan

[pnx]

Nice to have phpstan in this project to catch additional problems :)

[olssonm]

@pnx Thanks! Haven't worked much with PHPStan to be honest, will look through it all as soon as I've got the time!

[verifiera]

PHPDoc does not follow convention:
https://docs.phpdoc.org/3.0/guide/references/phpdoc/tags/property.html

There is a $ sign in front of variable names in @Property tag (all tags actually). PHPStorm allows variables without $, but this is not correct.

[verifiera]

PHPDoc does not follow convention: https://docs.phpdoc.org/3.0/guide/references/phpdoc/tags/property.html

There is a $ sign in front of variable names in @Property tag (all tags actually). PHPStorm allows variables without $, but this is not correct.

For example in Refund.php

[olssonm]

@verifiera – not sure what you mean? This PR by @pnx's adds $ for @property?

[verifiera]

@verifiera – not sure what you mean? This PR by @pnx's adds $ for @property?

PR does it also. Just wanted to say that to make it easy to use your great library in a project with PHPStan static analysis probably is enough to update @phpdocs for Olssonm\Swish\Refund (other classes looks correctly). Currently, there is a problem, we use your library in the project with phpstan integrated, and need handle the Refund class in a special way because $ signs are missing in @PHPDoc section.

[olssonm]

@pnx Thanks for your PR! A new release has been published (v2.1) and it should be available shortly via packagist.org.

[verifiera]

👍